Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move register types to x86_64_types crate #73

Closed
wants to merge 1 commit into from

Conversation

npmccallum
Copy link
Member

No description provided.

@npmccallum
Copy link
Member Author

@phil-opp FYI

@phil-opp
Copy link
Member

phil-opp commented May 4, 2019

Looks good to me in general. I don't think that we want to merge this into master directly, because git dependencies are not allowed on crates.io. I just created a dev branch, could you create a new pull request against that branch? This way, we can experiment with the split while keeping the master branch publishable.

@phil-opp phil-opp mentioned this pull request Jun 3, 2019
@npmccallum
Copy link
Member Author

@phil-opp Would it be better to just release a version of x86_64_types?

@phil-opp
Copy link
Member

phil-opp commented Jun 3, 2019

@npmccallum Yes, we could do that too. I just want to avoid repeated breaking changes of x86_64, so perhaps it's better to keep it in a separate branch to allow more experimentation on the type APIs?

@phil-opp
Copy link
Member

Closing as stale. I'm happy to continue experimentation on this matter if you like @npmccallum.

@phil-opp phil-opp closed this Apr 10, 2020
@npmccallum
Copy link
Member Author

@haraldh and @connorkuehl are mostly doing this work now.

@phil-opp
Copy link
Member

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants